Re: commented out code - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: commented out code
Date
Msg-id 8333bca3-2d7d-4513-b44d-a168e75171e9@eisentraut.org
Whole thread Raw
In response to Re: commented out code  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: commented out code
Re: commented out code
List pgsql-hackers
On 05.12.25 17:38, Heikki Linnakangas wrote:
> #if 0
>      Oid      subtype = PG_GETARG_OID(3);
> #endif
> 
> is yet another option. It keeps the indentation, although you won't get 
> the compiler checking.

After some reflection, I like this approach.  It keeps the indentation 
and enables syntax highlighting, so it makes some of these blocks much 
easier to read.

Here is an updated patch with this approach, except for jsonb_set_lax(), 
where the correct fix was to delete the commented out code, as 
previously discussed.

Attachment

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Speed up transaction completion faster after many relations are accessed in a transaction
Next
From: vignesh C
Date:
Subject: Re: Logical Replication of sequences