Re: Add missing JIT inline pass for llvm>=17 - Mailing list pgsql-hackers

Hi,

On 2026-01-16 10:10:07 +0100, Anthonin Bonnefoy wrote:
> On Thu, Jan 15, 2026 at 2:51 PM Andres Freund <andres@anarazel.de> wrote:
> > I'm strongly against removing the always inline pass, I see absolutely no
> > reason for doing that. The whole point of always inline is that it happens
> > unconditionally. It's not an expensive pass either.
> 
> I've looked into more details on what was provided by 'default<O0>',
> and it turns out it includes an always-inline pass[0]. This is also
> visible when using debug-pass-manager:

Ah, that's good to know!


> So, with 'default<O0>,mem2reg', we replicate the same behaviour as
> pre-LLVM17 as it includes the always-inline pass.
> 
> I've updated the patch to only add the inline pass when PGJIT_INLINE
> is on. I've also added a comment to mention that always-inline is
> included in O0.

That looks good to me.

Greetings,

Andres Freund