Re: commented out code - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: commented out code
Date
Msg-id a690f6d3-c53e-41cf-8a26-756b1ef16442@eisentraut.org
Whole thread Raw
In response to Re: commented out code  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 20.01.26 19:55, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> On 05.12.25 17:38, Heikki Linnakangas wrote:
>>> #if 0
>>>      Oid      subtype = PG_GETARG_OID(3);
>>> #endif
>>>
>>> is yet another option. It keeps the indentation, although you won't get
>>> the compiler checking.
> 
>> After some reflection, I like this approach.  It keeps the indentation
>> and enables syntax highlighting, so it makes some of these blocks much
>> easier to read.
> 
> I think "#ifdef NOT_USED" is our more common style.  +1 other than
> that nitpick.

Ok, committed like that.




pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Assert the timestamp is available for ORIGN_DIFFERS conflicts
Next
From: Henson Choi
Date:
Subject: Re: SQL Property Graph Queries (SQL/PGQ)