Re: Make description of heap records more talkative for flags - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Make description of heap records more talkative for flags
Date
Msg-id 152907530797.19071.16897844783986252441.pgcf@coridan.postgresql.org
Whole thread Raw
In response to Re: Make description of heap records more talkative for flags  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Make description of heap records more talkative for flags
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            not tested

-        appendStringInfo(buf, "off %u", xlrec->offnum);
+        appendStringInfo(buf, "off %u flags %02X", xlrec->offnum,
+                         xlrec->flags);

Can we add "0x" before the flags so that it is abundantly clear it's a
hex value?

Nathan

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: WAL prefetch
Next
From: Konstantin Knizhnik
Date:
Subject: Re: WAL prefetch