> On Fri, 15 Jun 2018 at 17:09, Nathan Bossart <bossartn@amazon.com> wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: not tested
> Implements feature: not tested
> Spec compliant: not tested
> Documentation: not tested
>
> - appendStringInfo(buf, "off %u", xlrec->offnum);
> + appendStringInfo(buf, "off %u flags %02X", xlrec->offnum,
> + xlrec->flags);
>
> Can we add "0x" before the flags so that it is abundantly clear it's a
> hex value?
This thread is being inactive for quite some time. As far as I understand, the
agreement was to add it in the PG12 commit cycle, so probably it's a good time
to do so. Any plans about that?