Re: Make description of heap records more talkative for flags - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: Make description of heap records more talkative for flags
Date
Msg-id CA+q6zcUD6oM0OAgiz6VbFYJSasjq2B5afTU8mdO2iDio+-3ZSw@mail.gmail.com
Whole thread Raw
In response to Re: Make description of heap records more talkative for flags  (Nathan Bossart <bossartn@amazon.com>)
Responses Re: Make description of heap records more talkative for flags
List pgsql-hackers
> On Fri, 15 Jun 2018 at 17:09, Nathan Bossart <bossartn@amazon.com> wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world:  not tested
> Implements feature:       not tested
> Spec compliant:           not tested
> Documentation:            not tested
>
> -               appendStringInfo(buf, "off %u", xlrec->offnum);
> +               appendStringInfo(buf, "off %u flags %02X", xlrec->offnum,
> +                                                xlrec->flags);
>
> Can we add "0x" before the flags so that it is abundantly clear it's a
> hex value?

This thread is being inactive for quite some time. As far as I understand, the
agreement was to add it in the PG12 commit cycle, so probably it's a good time
to do so. Any plans about that?


pgsql-hackers by date:

Previous
From: Adam Berlin
Date:
Subject: Re: Add extension options to control TAP and isolation tests
Next
From: Nikita Glukhov
Date:
Subject: Re: jsonpath