Re: pg_restore recognizing $-quotes - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: pg_restore recognizing $-quotes
Date
Msg-id 1453.24.211.141.25.1092843061.squirrel@www.dunslane.net
Whole thread Raw
In response to Re: pg_restore recognizing $-quotes  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_restore recognizing $-quotes
List pgsql-patches
Tom Lane said:
> "Andrew Dunstan" <andrew@dunslane.net> writes:
>> ISTM that a very simple alternative would be to force pg_dump to
>> inhibit dollar quoting for non-text dumps.
>
> I don't want to do that, but I did think that a simpler alternative
> would be to inhibit pg_restore from attempting to parse FUNCTION
> entries.  I can't see any strong need for it to do so.
>
> (I haven't had time to review Philip's patch either... but I think
> Bruce was asking whether to put it on the "awaiting review" list...
> definitely yes.)
>

OK. Not sure I understand why, though - the whole point of putting dollar
quoting into pg_dump was to make text dumps nicer to read, I thought (and I
outght to know ;-) ). Once the function is created you have no idea at all
if the body was originally dollar quoted or not.

cheers

andrew




pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_restore recognizing $-quotes
Next
From: Bruce Momjian
Date:
Subject: Re: pg_restore recognizing $-quotes