Postgres Pro
Downloads
Home   >   mailing lists

Re: [COMMITTERS] pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu - Mailing list pgsql-committers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu
Date
Msg-id 14181.1506366549@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Give a better error for duplicate entries inVACUUM/ANALYZE colu  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [COMMITTERS] pgsql: Give a better error for duplicate entries inVACUUM/ANALYZE colu
List pgsql-committers
Tree view 
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 9/21/17 18:13, Tom Lane wrote:
>> Give a better error for duplicate entries in VACUUM/ANALYZE column list.

> In the error message, we should write "specified more than once" instead
> of "specified twice", because that could otherwise look a bit silly:
> VACUUM ANALYZE vaccluster(i,i,i);
> ERROR:  column "i" of relation "vaccluster" is specified twice

OK.

> (Also, the "is" doesn't seem to fit there.)

Hm, reads fine to me, and I'd still rather include "is" in the
revised wording.  Anybody else agree with Peter's wording?
        regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [COMMITTERS] pgsql: Give a better error for duplicate entries inVACUUM/ANALYZE colu
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Avoid SIGBUS on Linux when a DSM memory request overruns tmpfs.