Postgres Pro
Downloads
Home   >   mailing lists

Re: [COMMITTERS] pgsql: Give a better error for duplicate entries inVACUUM/ANALYZE colu - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: [COMMITTERS] pgsql: Give a better error for duplicate entries inVACUUM/ANALYZE colu
Date
Msg-id 862733d5-f132-a59b-7afb-86002f946f80@2ndquadrant.com
Whole thread Raw
In response to [COMMITTERS] pgsql: Give a better error for duplicate entries in VACUUM/ANALYZEcolu  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tree view 
On 9/21/17 18:13, Tom Lane wrote:
> Give a better error for duplicate entries in VACUUM/ANALYZE column list.
> 
> Previously, the code didn't think about this case and would just try to
> analyze such a column twice.

In the error message, we should write "specified more than once" instead
of "specified twice", because that could otherwise look a bit silly:

VACUUM ANALYZE vaccluster(i,i,i);
ERROR:  column "i" of relation "vaccluster" is specified twice

(Also, the "is" doesn't seem to fit there.)

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Make construct_[md_]array return a valid empty array forzero-si
Next
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu