Re: Fix a wrong comment in load_file() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fix a wrong comment in load_file()
Date
Msg-id 1252412.1734925847@sss.pgh.pa.us
Whole thread Raw
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Dec 23, 2024 at 10:58:49AM +0800, cca5507 wrote:
>   * This function loads a shlib file without looking up any particular
>   * function in it.  If the same shlib has previously been loaded,
> - * unload and reload it.
> + * we don't load it again.

> Right.  This comment is misleading.

I think it was once correct, decades ago.  Obviously we missed
fixing it when we ripped out the unload functionality.

> -    /* Load the shared library */
> +    /* Load the shared library, unless we already did */

> This comment is still true, though.

Seems like an improvement to me?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: wrong comments in ClassifyUtilityCommandAsReadOnly
Next
From: mahendrakar s
Date:
Subject: Last removed wal segment file