Thread: Re: Fix a wrong comment in load_file()

Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Dec 23, 2024 at 10:58:49AM +0800, cca5507 wrote:
>   * This function loads a shlib file without looking up any particular
>   * function in it.  If the same shlib has previously been loaded,
> - * unload and reload it.
> + * we don't load it again.

> Right.  This comment is misleading.

I think it was once correct, decades ago.  Obviously we missed
fixing it when we ripped out the unload functionality.

> -    /* Load the shared library */
> +    /* Load the shared library, unless we already did */

> This comment is still true, though.

Seems like an improvement to me?

            regards, tom lane

Michael Paquier <michael@paquier.xyz> writes:
> While on it, I think that we should adjust all these ones too:
> contrib/sepgsql/hooks.c: * Module load/unload callback
> contrib/auto_explain/auto_explain.c:/* Saved hook values in case of
> unload */
> contrib/passwordcheck/passwordcheck.c:/* Saved hook value in case of
> unload */
> contrib/pg_stat_statements/pg_stat_statements.c:/* Saved hook values
> in case of unload */

Check.

> The saved hooks are not here to readjust the stack based on a reload,
> just to make sure that the existing paths loaded are all taken.  I
> would just remove the "in case of unload" part for the last three, and
> "unload" for the first one.  Thoughts?

WFM

            regards, tom lane