Re: wrong comments in ClassifyUtilityCommandAsReadOnly - Mailing list pgsql-hackers

From Tom Lane
Subject Re: wrong comments in ClassifyUtilityCommandAsReadOnly
Date
Msg-id 1250308.1734925060@sss.pgh.pa.us
Whole thread Raw
In response to wrong comments in ClassifyUtilityCommandAsReadOnly  (jian he <jian.universality@gmail.com>)
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> + *      The "DefineAggregate" routine take the parse tree and pick out the
> + *      appropriate arguments/flags, passing the results to
> + *      "AggregateCreate" routine (src src/backend/catalog) that do the actual
> + *      catalog-munging.  These routines also verify permission of the user to
> + *      execute the command.

The grammar needs some help here.  Also, rather than simply remove
define.c's entire header comment, maybe we should write something
relevant about what it does?  Good catches otherwise.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andreas Karlsson
Date:
Subject: Re: pure parsers and reentrant scanners
Next
From: Tom Lane
Date:
Subject: Re: Fix a wrong comment in load_file()