Re: Slow standby snapshot - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Slow standby snapshot
Date
Msg-id 1225350.1669757944@sss.pgh.pa.us
Whole thread Raw
In response to Re: Slow standby snapshot  (Michail Nikolaev <michail.nikolaev@gmail.com>)
List pgsql-hackers
Michail Nikolaev <michail.nikolaev@gmail.com> writes:
> The small thing I was thinking to add in KnownAssignedXidsCompress is
> the assertion like

> Assert(MyBackendType == B_STARTUP);

Mmm ... given where the call sites are, we have got lots more problems
than this if some non-startup process reaches them.  I'm not sure this
is worth the trouble, but if it is, I'd put it in the callers.

>> I'd be willing to
>> make the memory barrier change anyway, because that seems like
>> a simple change that can't hurt.

> I'm going to create a separate commit fest entry for it, ok?

Right, since I closed this one already.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Removing another gen_node_support.pl special case
Next
From: Jeff Davis
Date:
Subject: Re: Collation version tracking for macOS