Re: Hint Bits and Write I/O - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Hint Bits and Write I/O
Date
Msg-id 1214578436.3845.413.camel@ebony.site
Whole thread Raw
In response to Re: Hint Bits and Write I/O  (Gregory Stark <stark@enterprisedb.com>)
List pgsql-hackers
On Fri, 2008-06-27 at 15:25 +0100, Gregory Stark wrote:
> "Alvaro Herrera" <alvherre@commandprompt.com> writes:
>
> > If only VACUUM is going to set "flexible" to off, maybe it's better to
> > leave the APIs as they are and have a global that's set by VACUUM only
> > (and reset in a PG_CATCH block).
>
> Ugh. Perhaps it would be simpler to have a wrapper function HTSV() macro which
> passes flexible=true to HTSV_internal(). Then vacuum can call HTSV_internal().
>
> I'm not sure what the performance tradeoff is between having an extra argument
> to HTSV and having HTSV check a global which messes with optimizations.

Doing this doesn't actually reduce the size of the patch much, as it
turns out, so I suggest we don't do this.

--
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: ALTER DATABASE vs pg_dump
Next
From: Jeff McKenna
Date:
Subject: Re: MSVC 2003 compile error with pg8.3.3