Re: pg_dump output portability - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_dump output portability
Date
Msg-id 1067.1029442380@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_dump output portability  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> Tom Lane writes:
>> Switching the default is definitely fine with me, but I'd lean towards
>> ripping it out entirely, given that the backend-supplied chunks of stuff
>> are not going to have extra quotes.  We always tell people "always quote
>> or never quote" a given identifier; pg_dump scripts ought to follow that
>> rule.

> It occurred to me that pg_dump would need to know which names are
> keywords.  Ugh.

Good point, but not insurmountable.  We could easily make pg_dump
include the backend's src/backend/parser/keywords.o file and then
use that subroutine to test for keyword-ness.  This would be a 100%
solution when dumping from a server of the same version, and about
a 99.9% solution when dumping from an older server.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Vince Vielhaber
Date:
Subject: Re: Open 7.3 items
Next
From: Tom Lane
Date:
Subject: Re: Standard replication interface?