Re: pg_dump output portability - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: pg_dump output portability
Date
Msg-id Pine.LNX.4.44.0208152126500.20055-100000@localhost.localdomain
Whole thread Raw
In response to Re: pg_dump output portability  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_dump output portability  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane writes:

> Ah.  But where exactly will you substitute true for 't'?  I don't think
> pg_dump necessarily knows enough to apply that transformation.

Sure, it does it already for other types.  Look for BITOID in pg_dump.c.

> Switching the default is definitely fine with me, but I'd lean towards
> ripping it out entirely, given that the backend-supplied chunks of stuff
> are not going to have extra quotes.  We always tell people "always quote
> or never quote" a given identifier; pg_dump scripts ought to follow that
> rule.

It occurred to me that pg_dump would need to know which names are
keywords.  Ugh.

-- 
Peter Eisentraut   peter_e@gmx.net



pgsql-hackers by date:

Previous
From: "Marc G. Fournier"
Date:
Subject: Re: failure notice (fwd)
Next
From: Peter Eisentraut
Date:
Subject: Re: pg_dump large file support