Re: pg_locale compilation error with Visual Studio 2017 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_locale compilation error with Visual Studio 2017
Date
Msg-id 10579.1526145097@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_locale compilation error with Visual Studio 2017  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Fri, May 11, 2018 at 10:39:07AM -0400, Tom Lane wrote:
>> Another idea would be to replace the whole mess with a lookup table,
>> although how to fill the table or maintain it in future would be
>> problematic too.

> Let's never do that..

Well, I dunno.  There are a couple of advantages:

* It'd be independent of MSVC version, presumably, so we could
hope that it would stay fixed.

* It'd work for MinGW builds, which the current solution doesn't
(according to the comments in IsoLocaleName anyway).

Maintenance would be an issue, of course, but I doubt it'd be any
worse than for the Windows-timezone-name lookup table we have in
initdb/findtimezone.c.  Which we've only touched twice in the last
seven years, AFAICT, and only one of those was per user complaint.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Should we add GUCs to allow partition pruning to be disabled?
Next
From: Peter Geoghegan
Date:
Subject: Re: Postgres 11 release notes