On 27.09.22 17:35, Nazir Bilal Yavuz wrote:
> I updated my patch regarding these reviews.
>
> The current logic is it will try to find all executables in that
> order(if it finds all executables, it won't try remaining steps):
>
>
> 1 - 'krb5-config --prefix'
>
> 2 - hardcoded paths(I added arm and MacPorts paths for darwin)
>
> 3 - from PATH
>
> Also, I tried to do some refactoring for adding another paths to search
> in the future and being sure about all executables are found.
This patch could use some more in-code comments. For example, this
+# get prefix for kerberos executables and try to find them at this path
+sub test_krb5_paths
is not helpful. What does it "get", where does it put it, how does it
"try", and what does it do if it fails? What are the inputs and outputs
of this function?
+ # remove '\n' since 'krb5-config --prefix' returns path ends with '\n'
+ $krb5_path =~ s/\n//g;
use chomp
