Re: pgbench: option delaying queries till connections establishment? - Mailing list pgsql-hackers

Hello!

On 2020-11-13 08:44, kuroda.hayato@fujitsu.com wrote:
> Dear Fabien,
> 
>> and this will wait till its time comes. In the mean time, I think that 
>> you
>> should put the patch status as you see fit, independently of the other
>> patch: it seems unlikely that they would be committed together, and 
>> I'll
>> have to merge the remaining one anyway.
> 
> OK. I found the related thread[1], and I understood you will submit
> another patch
> on the thread.
> 
> PostgreSQL Patch Tester says all regression tests are passed, and
> I change the status to "Ready for committer."
> 
> [1]: https://commitfest.postgresql.org/31/2827/
> 
> Thank you for discussing with me.
> 
> Hayato Kuroda
> FUJITSU LIMITED

 From the mentioned thread [2]:

>>> While trying to test a patch that adds a synchronization barrier in 
>>> pgbench [1] on Windows,
>> 
>> Thanks for trying that, I do not have a windows setup for testing, and
>> the sync code I wrote for Windows is basically blind coding:-(
> 
> FYI:
> 
> 1) It looks like pgbench will no longer support Windows XP due to the
> function DeleteSynchronizationBarrier. From
> https://docs.microsoft.com/en-us/windows/win32/api/synchapi/nf-synchapi-deletesynchronizationbarrier
> :
> 
> Minimum supported client: Windows 8 [desktop apps only]
> Minimum supported server: Windows Server 2012 [desktop apps only]
> 
> On Windows Server 2008 R2 (MSVC 2013) the 6-th version of the patch
> [1] has compiled without (new) warnings, but when running pgbench I
> got the following error:
> 
> The procedure entry point DeleteSynchronizationBarrier could not be
> located in the dynamic link library KERNEL32.dll.

IMO, it looks like either old Windows systems should not call new 
functions, or we should throw them a compilation error. (Update 
MIN_WINNT to 0x0602 = Windows 8 in src/include/port/win32.h?) In the 
second case it looks like the documentation should be updated too, see 
doc/src/sgml/installation.sgml:

<para>
  <productname>PostgreSQL</productname> can be expected to work on these 
operating
  systems: Linux (all recent distributions), Windows (XP and later),
  FreeBSD, OpenBSD, NetBSD, macOS, AIX, HP/UX, and Solaris.
  Other Unix-like systems may also work but are not currently
  being tested.  In most cases, all CPU architectures supported by
  a given operating system will work.  Look in
  <xref linkend="installation-platform-notes"/> below to see if
  there is information
  specific to your operating system, particularly if using an older 
system.
</para>

<...>

<para>
  The native Windows port requires a 32 or 64-bit version of Windows
  2000 or later. Earlier operating systems do
  not have sufficient infrastructure (but Cygwin may be used on
  those).  MinGW, the Unix-like build tools, and MSYS, a collection
  of Unix tools required to run shell scripts
  like <command>configure</command>, can be downloaded
  from <ulink url="http://www.mingw.org/"></ulink>.  Neither is
  required to run the resulting binaries; they are needed only for
  creating the binaries.
</para>

[2] 
https://www.postgresql.org/message-id/e5a09b790db21356376b6e73673aa07c%40postgrespro.ru

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company