On 3/27/20 6:13 PM, Fabien COELHO wrote:
>
> Hello David,
>
>>>> I'd prefer not to expand the use of pqexpbuffer in more places, and
>>>> instead rather see this use StringInfo, now that's also available to
>>>> frontend programs.
>>>
>>> Franckly, one or the other does not matter much to me.
>>
>> FWIW, I agree with Andres with regard to using StringInfo.
>
> Ok. I find it strange to mix PQExpBuffer & StringInfo in the same file.
Agreed, but we'd rather use StringInfo going forward. However, I don't
think that puts you on the hook for updating all the PQExpBuffer references.
Unless you want to...
>> Also, the changes to executeStatementExpect() and adding
>> executeStatement() do not seem to fit in with the purpose of this patch.
>
> Yep, that was in passing.
>
> Attached a v6 which uses StringInfo, and the small refactoring as a
> separate patch.
I think that's better, thanks.
Regards,
--
-David
david@pgmasters.net
