Re: pgbench - refactor init functions with buffers - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench - refactor init functions with buffers
Date
Msg-id alpine.DEB.2.21.2003272354490.16227@pseudo
Whole thread Raw
In response to Re: pgbench - refactor init functions with buffers  (David Steele <david@pgmasters.net>)
Responses Re: pgbench - refactor init functions with buffers  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
>> Ok. I find it strange to mix PQExpBuffer & StringInfo in the same file.
>
> Agreed, but we'd rather use StringInfo going forward.  However, I don't think 
> that puts you on the hook for updating all the PQExpBuffer references.
>
> Unless you want to...

I cannot say that I "want" to fix something which already works the same 
way, because it is against my coding principles.

However there may be some fun in writing a little script to replace one 
with the other automatically. I counted nearly 3500 calls under src/bin.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Berserk Autovacuum (let's save next Mandrill)
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove pgbench "progress" test pending solution of its timing is (fwd)