RE: static global variable openLogOff in xlog.c seems no longer used - Mailing list pgsql-hackers

From Takashi Menjo
Subject RE: static global variable openLogOff in xlog.c seems no longer used
Date
Msg-id 001301d4b7af$1373e830$3a5bb890$@lab.ntt.co.jp
Whole thread Raw
In response to Re: static global variable openLogOff in xlog.c seems no longer used  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Michael Paquier wrote:
> It seems to me that keeping openLogOff is still useful to get a report
> about the full chunk area being written if the data gets written in
> multiple chunks and fails afterwards.  Your patch would modify the
> report so as only the area with the partial write is reported.  For
> debugging, having a static reference is also useful in my opinion.

I agree with you on both error reporting and debugging.  Now that you
mention it, I find that my patch modifies ereport...

When I wrote a patchset to xlog.c (in another email thread), I thought that
this can be fixed. But now I understand it is not a simple thing.  Thank
you.


Regards,
Takashi

-- 
Takashi Menjo - NTT Software Innovation Center
<menjo.takashi@lab.ntt.co.jp>




pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: COPY FROM WHEN condition
Next
From: Konstantin Knizhnik
Date:
Subject: Re: Built-in connection pooler