Thread: [PATCH] Fix missing comma in Requires.private with a Make macro

Hello!

Wolfgang reported over in [1] that I've missed a comma when appending
to the PKG_CONFIG_REQUIRES_PRIVATE list, making libpq.pc look ugly:

    Requires.private: libssl, libcrypto libcurl

pkg-config itself appears to be papering over my mistake (a quick code
inspection suggests it treats commas as equivalent to whitespace?) but
here's a patch to fix it. I went with a macro inspired by
Makefile.global's add_to_path, to try to ease this for whoever comes
next.

Tested with GNU Make 3.81 (the compilation of which was slightly
painful; does anyone want to debate pulling that minimum version up
sometime soon?) and 4.3.

Thanks,
--Jacob

[1] https://postgr.es/m/9badbeeb-a432-48d4-8710-c8254a54d428%40technowledgy.de

On Wed, May 7, 2025 at 11:55 AM Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
> LGTM

Thanks for the review!

>> Tested with GNU Make 3.81 (the compilation of which was slightly
>> painful; does anyone want to debate pulling that minimum version up
>> sometime soon?) and 4.3.
>
> Not sure if all animals have a minimum 4.3 make version. Do you?

Oh, I doubt that very much. I don't immediately see the Make version
in the configure logs for the animals, but lapwing for example is
running Debian Wheezy.

--Jacob

On 2025-May-07, Tom Lane wrote:

> Apple is still shipping
> 
> $ which make
> /usr/bin/make
> 
> $ make --version
> GNU Make 3.81

Well, Jacob did say that he tested it with 3.81, so this patch should be
okay.  Upping the minimum version can be discussed elsewhere ... or
maybe never, if we end up replacing it wholesale with Meson/ninja.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

On Wed, May 7, 2025 at 3:39 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
> Well, Jacob did say that he tested it with 3.81, so this patch should be
> okay.  Upping the minimum version can be discussed elsewhere ... or
> maybe never, if we end up replacing it wholesale with Meson/ninja.

To be fair, I did invite debate. I don't mind if it happens here. :D

Sounds like the debate might be fairly short, though. I was hoping the
choice of Make came from that old Debian box. But since it's actually
coming from Apple and I guess they have no plans to ever update... I
don't think you all need to change macOS setups on my account. I'd
imagine that people are not writing new Makefile macros very often.

Is there maybe a wiki page where we gather the reasoning for our
pinned minimum versions? None of my searches turned anything up, but
it might help accelerate some of these conversations.

Thanks!
--Jacob

Jacob Champion <jacob.champion@enterprisedb.com> writes:
> Is there maybe a wiki page where we gather the reasoning for our
> pinned minimum versions? None of my searches turned anything up, but
> it might help accelerate some of these conversations.

I'm not aware of one, but it seems like a reasonable idea ...

            regards, tom lane