[PATCH] Fix missing comma in Requires.private with a Make macro - Mailing list pgsql-hackers

From Jacob Champion
Subject [PATCH] Fix missing comma in Requires.private with a Make macro
Date
Msg-id CAOYmi+k2z7Rqj5xiWLUT0+bSXLvdE7TYgS5gCOSqSyXyTSSXiQ@mail.gmail.com
Whole thread Raw
List pgsql-hackers
Hello!

Wolfgang reported over in [1] that I've missed a comma when appending
to the PKG_CONFIG_REQUIRES_PRIVATE list, making libpq.pc look ugly:

    Requires.private: libssl, libcrypto libcurl

pkg-config itself appears to be papering over my mistake (a quick code
inspection suggests it treats commas as equivalent to whitespace?) but
here's a patch to fix it. I went with a macro inspired by
Makefile.global's add_to_path, to try to ease this for whoever comes
next.

Tested with GNU Make 3.81 (the compilation of which was slightly
painful; does anyone want to debate pulling that minimum version up
sometime soon?) and 4.3.

Thanks,
--Jacob

[1] https://postgr.es/m/9badbeeb-a432-48d4-8710-c8254a54d428%40technowledgy.de

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: fixing CREATEROLE
Next
From: Peter Geoghegan
Date:
Subject: Re: Adding skip scan (including MDAM style range skip scan) to nbtree