Thread: Re: Review/Pull Request: Adding new CRC32C implementation for IBM S390X

Hi Eduard,

> Here I send a patch that adds a vectorized version of CRC32C for the
> IBM S390X hardware. I kindly ask for a review of the code and to pick
> it up in upstream postgresql.
> [...]
> Cheers and thanks to all for their work,

Thanks for submitting this patch.

Please register it on the nearest open commitfest [1] so that it
wouldn't be lost.

I didn't review the patch but wanted to point out that when it comes
to performance improvements it's typically useful to provide some
benchmarks.

[1]: https://commitfest.postgresql.org/53/

-- 
Best regards,
Aleksander Alekseev

On Wed, May 7, 2025 at 8:15 PM Aleksander Alekseev
<aleksander@timescale.com> wrote:
>
> I didn't review the patch but wanted to point out that when it comes
> to performance improvements it's typically useful to provide some
> benchmarks.

+1 -- It's good to have concrete numbers for the commit message, and
also to verify improvement on short inputs. There is a test harness in
the  v7-0002 patch from here:

https://www.postgresql.org/message-id/CANWCAZaD5niydBF6q3V_cjApNV05cw-LpxxFtMbwDPLsz-PjbQ@mail.gmail.com

After building, run the "test-crc.sh" script here after executing
"CREATE EXTENSION test_crc32c;":

https://www.postgresql.org/message-id/CANWCAZahvhE-%2BhtZiUyzPiS5e45ukx5877mD-dHr-KSX6LcdjQ%40mail.gmail.com



--
John Naylor
Amazon Web Services