Re: Review/Pull Request: Adding new CRC32C implementation for IBM S390X - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Review/Pull Request: Adding new CRC32C implementation for IBM S390X
Date
Msg-id CAJ7c6TMian+pDWJeqZ584ix_ht_rR_PHxZfWgrriRtxjGw2Jrg@mail.gmail.com
Whole thread Raw
Responses Re: Review/Pull Request: Adding new CRC32C implementation for IBM S390X
List pgsql-hackers
Hi Eduard,

> Here I send a patch that adds a vectorized version of CRC32C for the
> IBM S390X hardware. I kindly ask for a review of the code and to pick
> it up in upstream postgresql.
> [...]
> Cheers and thanks to all for their work,

Thanks for submitting this patch.

Please register it on the nearest open commitfest [1] so that it
wouldn't be lost.

I didn't review the patch but wanted to point out that when it comes
to performance improvements it's typically useful to provide some
benchmarks.

[1]: https://commitfest.postgresql.org/53/

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Nisha Moond
Date:
Subject: Re: Fix slot synchronization with two_phase decoding enabled
Next
From: Yugo Nagata
Date:
Subject: Re: Improve tab completion for COPY