Thread: BUG #18850: REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison

The following bug has been logged on the website:

Bug reference:      18850
Logged by:          Nikita
Email address:      pm91.arapov@gmail.com
PostgreSQL version: 16.6
Operating system:   ubuntu 20.04
Description:

REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison

diff --git a/src/backend/commands/operatorcmds.c
b/src/backend/commands/operatorcmds.c
--- a/src/backend/commands/operatorcmds.c    (revision
a49ac80219c6f28c3cf3973f797de637329952da)
+++ b/src/backend/commands/operatorcmds.c    (date 1740387217614)
@@ -209,11 +209,6 @@
         typeId[0] = typeId2;
         nargs = 1;
     }
-    else if (!OidIsValid(typeId2))
-    {
-        typeId[0] = typeId1;
-        nargs = 1;
-    }
     else
     {
         typeId[0] = typeId1;

I suggest the following patch fixing this issue

PG Bug reporting form <noreply@postgresql.org> writes:
> REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison

Let's see, in #18848 and #18849 you were complaining about
non-robust code, but here you want to remove robustness?
I think it's fine as-is.  (The back story here is that we
used to support postfix operators, so the earlier error
for !OidIsValid(typeId2) postdates this bit.  While I don't
think that support is ever coming back, I'm disinclined to
remove a couple of lines that would be important for it.)

            regards, tom lane