Re: BUG #18850: REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #18850: REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison
Date
Msg-id 3055986.1741962724@sss.pgh.pa.us
Whole thread Raw
In response to BUG #18850: REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison  (PG Bug reporting form <noreply@postgresql.org>)
List pgsql-bugs
PG Bug reporting form <noreply@postgresql.org> writes:
> REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison

Let's see, in #18848 and #18849 you were complaining about
non-robust code, but here you want to remove robustness?
I think it's fine as-is.  (The back story here is that we
used to support postfix operators, so the earlier error
for !OidIsValid(typeId2) postdates this bit.  While I don't
think that support is ever coming back, I'm disinclined to
remove a couple of lines that would be important for it.)

            regards, tom lane



pgsql-bugs by date:

Previous
From: Viktor Holmberg
Date:
Subject: Re: ISN extension - wrong volatility level for isn_weak() function
Next
From: Tom Lane
Date:
Subject: Re: ISN extension - wrong volatility level for isn_weak() function