Thread: Enhances pg_createsubscriber documentation for the -d option.
Hi, Currently, pg_createsubscriber converts streaming replication to logical replication using the specified database name. If the database name is not provided, it is obtained from the --publisher-server option. If the database name is not specified in either the --database or --publisher-server option, an error is reported. This behavior is not documented. The attached patch includes the necessary documentation updates. Regards, Vignesh
Attachment
On Wed, Feb 26, 2025 at 11:34 AM vignesh C <vignesh21@gmail.com> wrote:
>
> Currently, pg_createsubscriber converts streaming replication to
> logical replication using the specified database name. If the database
> name is not provided, it is obtained from the --publisher-server
> option. If the database name is not specified in either the --database
> or --publisher-server option, an error is reported. This behavior is
> not documented. The attached patch includes the necessary
> documentation updates.
>
<para>
The name of the database in which to create a subscription. Multiple
databases can be selected by writing multiple <option>-d</option>
- switches.
+ switches. If this option is not provided, the database name will be
+ obtained from <option>-P</option>. If the database name is not specified
+ in either the <option>-d</option> option or <option>-P</option>, an
+ error is reported.
How about changing it slightly as follows to make it clear: "If
<option>-d</option>option is not provided, the database name will be
obtained from <option>-P</option>. If the database name is not
specified in either the <option>-d</option> option or
<option>-P</option>, an error will be reported."?
--
With Regards,
Amit Kapila.
On Wed, 26 Feb 2025 at 14:35, Amit Kapila <amit.kapila16@gmail.com> wrote: > > How about changing it slightly as follows to make it clear: "If > <option>-d</option>option is not provided, the database name will be > obtained from <option>-P</option>. If the database name is not > specified in either the <option>-d</option> option or > <option>-P</option>, an error will be reported."? Looks good to me, here is an updated v2 version with the changes. Regards, Vignesh
Attachment
On Wed, Feb 26, 2025 at 4:48 PM vignesh C <vignesh21@gmail.com> wrote: > > On Wed, 26 Feb 2025 at 14:35, Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > How about changing it slightly as follows to make it clear: "If > > <option>-d</option>option is not provided, the database name will be > > obtained from <option>-P</option>. If the database name is not > > specified in either the <option>-d</option> option or > > <option>-P</option>, an error will be reported."? > > Looks good to me, here is an updated v2 version with the changes. > Pushed. -- With Regards, Amit Kapila.