Re: Enhances pg_createsubscriber documentation for the -d option. - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Enhances pg_createsubscriber documentation for the -d option.
Date
Msg-id CAA4eK1J3fdNnACpyUaKty061Hb19o=jSB_QpTD0h9EV1f+wagQ@mail.gmail.com
Whole thread Raw
In response to Enhances pg_createsubscriber documentation for the -d option.  (vignesh C <vignesh21@gmail.com>)
Responses Re: Enhances pg_createsubscriber documentation for the -d option.
List pgsql-hackers
On Wed, Feb 26, 2025 at 11:34 AM vignesh C <vignesh21@gmail.com> wrote:
>
> Currently, pg_createsubscriber converts streaming replication to
> logical replication using the specified database name. If the database
> name is not provided, it is obtained from the --publisher-server
> option. If the database name is not specified in either the --database
> or --publisher-server option, an error is reported. This behavior is
> not documented. The attached patch includes the necessary
> documentation updates.
>

<para>
        The name of the database in which to create a subscription.  Multiple
        databases can be selected by writing multiple <option>-d</option>
-       switches.
+       switches. If this option is not provided, the database name will be
+       obtained from <option>-P</option>. If the database name is not specified
+       in either the <option>-d</option> option or <option>-P</option>, an
+       error is reported.

How about changing it slightly as follows to make it clear: "If
<option>-d</option>option is not provided, the database name will be
obtained from <option>-P</option>. If the database name is not
specified in either the <option>-d</option> option or
<option>-P</option>, an error will be reported."?

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Proposal: Limitations of palloc inside checkpointer
Next
From: Corey Huinker
Date:
Subject: Re: Statistics Import and Export