Thread: Re: Avoid updating inactive_since for invalid replication slots

On Tue, 4 Feb 2025 at 11:52, Nisha Moond <nisha.moond412@gmail.com> wrote:
>
> Here is the v2 patch with above change and other comments from [1] and
> [2] incorporated.

One small suggestion:
Since we will not be retaining inactive time for invalid slots after
server restart, the inactive time will be lost in this case, shouldn't
we include mentioning that too:
         The time when the slot became inactive. <literal>NULL</literal> if the
-        slot is currently being streamed.
+        slot is currently being streamed. If the slot becomes invalid,
+        this value will not be updated.

Regards,
Vignesh

On Tue, Feb 4, 2025 at 12:05 PM vignesh C <vignesh21@gmail.com> wrote:
>
> On Tue, 4 Feb 2025 at 11:52, Nisha Moond <nisha.moond412@gmail.com> wrote:
> >
> > Here is the v2 patch with above change and other comments from [1] and
> > [2] incorporated.
>
> One small suggestion:
> Since we will not be retaining inactive time for invalid slots after
> server restart, the inactive time will be lost in this case, shouldn't
> we include mentioning that too:
>          The time when the slot became inactive. <literal>NULL</literal> if the
> -        slot is currently being streamed.
> +        slot is currently being streamed. If the slot becomes invalid,
> +        this value will not be updated.
>

The current update seems sufficient even for restart cases. It
indicates that inactive_sinsce is not updated for invalid slots
whether its restart or otherwise.

--
With Regards,
Amit Kapila.