Re: Avoid updating inactive_since for invalid replication slots - Mailing list pgsql-hackers

From vignesh C
Subject Re: Avoid updating inactive_since for invalid replication slots
Date
Msg-id CALDaNm0QFB1C6xVKfpS2FtPwBbxW0W-yRh9nOCdzGY=EvAd=Dg@mail.gmail.com
Whole thread Raw
Responses Re: Avoid updating inactive_since for invalid replication slots
List pgsql-hackers
On Tue, 4 Feb 2025 at 11:52, Nisha Moond <nisha.moond412@gmail.com> wrote:
>
> Here is the v2 patch with above change and other comments from [1] and
> [2] incorporated.

One small suggestion:
Since we will not be retaining inactive time for invalid slots after
server restart, the inactive time will be lost in this case, shouldn't
we include mentioning that too:
         The time when the slot became inactive. <literal>NULL</literal> if the
-        slot is currently being streamed.
+        slot is currently being streamed. If the slot becomes invalid,
+        this value will not be updated.

Regards,
Vignesh



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Increased work_mem for "logical replication tablesync worker" only?
Next
From: Daniel Gustafsson
Date:
Subject: Re: new commitfest transition guidance