Postgres Pro
Downloads
Home   >   mailing lists

Thread: Require suggestions on feature 6794

Require suggestions on feature 6794

From
Pravesh Sharma
Date:
Hi Dave/Team

I have started working on feature #6794. The user wants to pass connection information, such as host, port, and username, to the passexec command without hardcoding these values. I plan to implement it as follows: The user will set environment variables for the host, port, and username, and before running the passexec command, we will replace the corresponding values with the environment variables.


Please share your suggestions or feedback on the approach I am proposing.


Thanks,

Pravesh


--


Pravesh Sharma

Senior SDE

+91 9406461406


enterprisedb.com

Re: Require suggestions on feature 6794

From
Dave Page
Date:
Hi

On Tue, 26 Nov 2024 at 10:55, Pravesh Sharma <pravesh.sharma@enterprisedb.com> wrote:
Hi Dave/Team

I have started working on feature #6794. The user wants to pass connection information, such as host, port, and username, to the passexec command without hardcoding these values. I plan to implement it as follows: The user will set environment variables for the host, port, and username, and before running the passexec command, we will replace the corresponding values with the environment variables.


Please share your suggestions or feedback on the approach I am proposing.


I'm not sure why the user would need to set environment variables - wouldn't pgAdmin just set them in the environment of the passexec process, based on the server definition?

--

Re: Require suggestions on feature 6794

From
Aditya Toshniwal
Date:
Hi Pravesh,

In addition to that, why do we need env vars at all? We can simply pass them as arguments to passexec script. It's up to the users to use it or ignore it.

On Tue, Nov 26, 2024 at 4:54 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, 26 Nov 2024 at 10:55, Pravesh Sharma <pravesh.sharma@enterprisedb.com> wrote:
Hi Dave/Team

I have started working on feature #6794. The user wants to pass connection information, such as host, port, and username, to the passexec command without hardcoding these values. I plan to implement it as follows: The user will set environment variables for the host, port, and username, and before running the passexec command, we will replace the corresponding values with the environment variables.


Please share your suggestions or feedback on the approach I am proposing.


I'm not sure why the user would need to set environment variables - wouldn't pgAdmin just set them in the environment of the passexec process, based on the server definition?

--


--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Staff SDE II | enterprisedb.com
"Don't Complain about Heat, Plant a TREE"

Re: Require suggestions on feature 6794

From
Dave Page
Date:


On Tue, 26 Nov 2024 at 11:30, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Pravesh,

In addition to that, why do we need env vars at all? We can simply pass them as arguments to passexec script. It's up to the users to use it or ignore it.

Or do some string substitution in the command, e.g.

/path/to/passexec.sh $HOST$ $PORT$

or similar, so the user has even more flexibility. I know that is done in PEM in a few places, possibly in pgAdmin too, though I don't recall offhand (if it is, we should be consistent on how the parameters are notated).

--