Re: Require suggestions on feature 6794 - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: Require suggestions on feature 6794
Date
Msg-id CAM9w-_kvjS_g1ZX5So=zMo-eJ=8H4_Ws=mfDEcDR92ftG4V3UA@mail.gmail.com
Whole thread Raw
In response to Re: Require suggestions on feature 6794  (Dave Page <dpage@pgadmin.org>)
Responses Re: Require suggestions on feature 6794
List pgadmin-hackers
Hi Pravesh,

In addition to that, why do we need env vars at all? We can simply pass them as arguments to passexec script. It's up to the users to use it or ignore it.

On Tue, Nov 26, 2024 at 4:54 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, 26 Nov 2024 at 10:55, Pravesh Sharma <pravesh.sharma@enterprisedb.com> wrote:
Hi Dave/Team

I have started working on feature #6794. The user wants to pass connection information, such as host, port, and username, to the passexec command without hardcoding these values. I plan to implement it as follows: The user will set environment variables for the host, port, and username, and before running the passexec command, we will replace the corresponding values with the environment variables.


Please share your suggestions or feedback on the approach I am proposing.


I'm not sure why the user would need to set environment variables - wouldn't pgAdmin just set them in the environment of the passexec process, based on the server definition?

--


--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Staff SDE II | enterprisedb.com
"Don't Complain about Heat, Plant a TREE"

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Require suggestions on feature 6794
Next
From: Dave Page
Date:
Subject: Re: Require suggestions on feature 6794