Thread: Re: Shave a few cycles off our ilog10 implementation

Re: Shave a few cycles off our ilog10 implementation

From
Heikki Linnakangas
Date:
On 30/10/2024 21:27, David Fetter wrote:
> Please find attached a patch to $Subject
> 
> I've done some preliminary testing, and it appears to shave somewhere
> between 25-50% off the operations themselves, and these cascade into
> things like formatting result sets and COPY OUT.

Impressive! What did you use to performance test it, to get those results?

-- 
Heikki Linnakangas
Neon (https://neon.tech)




Re: Shave a few cycles off our ilog10 implementation

From
David Fetter
Date:
On Wed, Oct 30, 2024 at 09:54:20PM +0200, Heikki Linnakangas wrote:
> On 30/10/2024 21:27, David Fetter wrote:
> > Please find attached a patch to $Subject
> > 
> > I've done some preliminary testing, and it appears to shave somewhere
> > between 25-50% off the operations themselves, and these cascade into
> > things like formatting result sets and COPY OUT.
> 
> Impressive! What did you use to performance test it, to get those results?

In case that wasn't clear, what I've tested so far was the ilog10
implementations, not the general effects on the things they underlie.

This testing was basically just sending a bunch of appropriately sized
pseudo-random uints in a previously created array sent through a tight
loop that called the ilog10s and getting average execution times.

Any suggestions for more thorough testing would be welcome.

Best,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778



Re: Shave a few cycles off our ilog10 implementation

From
David Rowley
Date:
On Thu, 31 Oct 2024 at 09:02, David Fetter <david@fetter.org> wrote:
> This testing was basically just sending a bunch of appropriately sized
> pseudo-random uints in a previously created array sent through a tight
> loop that called the ilog10s and getting average execution times.
>
> Any suggestions for more thorough testing would be welcome.

Maybe something similar to what I did in [1].

David

[1] https://postgr.es/m/CAApHDvopR=yPgNr4AbbN4HMOztuyVa+iFYRTvu49pxg9YO_tKw@mail.gmail.com