Thread: Missing reflection in nls.mk from recent basebackup changes
Hello. After a recent commit f80b09bac8, make update-po fails with "missing required files". The commit moved some files to fe_utils but this change was not reflected in pg_basebackup's nls.mk. The attached patch fixes this issue. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
Attachment
On Tue, Aug 06, 2024 at 10:21:23AM +0900, Kyotaro Horiguchi wrote: > After a recent commit f80b09bac8, make update-po fails with "missing > required files". The commit moved some files to fe_utils but this > change was not reflected in pg_basebackup's nls.mk. The attached patch > fixes this issue. You are right. Still, it is not something that committers are required to update when introducing new files, isn't it? I don't see why we should be aggressive here for HEAD. ad8877cb5137 has done a large batch of these for the v17 cycle. -- Michael
Attachment
On 2024-Aug-06, Michael Paquier wrote: > On Tue, Aug 06, 2024 at 10:21:23AM +0900, Kyotaro Horiguchi wrote: > > After a recent commit f80b09bac8, make update-po fails with "missing > > required files". The commit moved some files to fe_utils but this > > change was not reflected in pg_basebackup's nls.mk. The attached patch > > fixes this issue. > > You are right. Still, it is not something that committers are > required to update when introducing new files, isn't it? I don't see > why we should be aggressive here for HEAD. Well, make targets should always work. > ad8877cb5137 has done a large batch of these for the v17 cycle. IIUC that's slightly different -- it concerns files that contain *additional* files that msgmerge need to scan in order to extract translatable strings. This patch is about fixing bogus file locations in the makefiles. So without this patch, update-po fails; without the commit you mention, update-po continues to run, the only problem is it misses a few files. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "El sentido de las cosas no viene de las cosas, sino de las inteligencias que las aplican a sus problemas diarios en busca del progreso." (Ernesto Hernández-Novich)
On 2024-Aug-06, Kyotaro Horiguchi wrote: > After a recent commit f80b09bac8, make update-po fails with "missing > required files". The commit moved some files to fe_utils but this > change was not reflected in pg_basebackup's nls.mk. The attached patch > fixes this issue. Thanks, pushed! -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "Cómo ponemos nuestros dedos en la arcilla del otro. Eso es la amistad; jugar al alfarero y ver qué formas se pueden sacar del otro" (C. Halloway en La Feria de las Tinieblas, R. Bradbury)