Thread: Incorrect grammar in 15.2

Incorrect grammar in 15.2

From
PG Doc comments form
Date:
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/16/when-can-parallel-query-be-used.html
Description:

Unless I'm misunderstanding the sentence structure here, I believe the word
"a" is missing before "parallel query plan" in the following sentence from
section 15.2:

> Even when parallel query plan is generated for a particular query, there
are several circumstances under which it will be impossible to execute that
plan in parallel at execution time.

This should say:

> Even when a parallel query plan is generated for a particular query, there
are several circumstances under which it will be impossible to execute that
plan in parallel at execution time.

Re: Incorrect grammar in 15.2

From
Laurenz Albe
Date:
On Wed, 2024-07-24 at 05:11 +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/16/when-can-parallel-query-be-used.html
> Description:
>
> Unless I'm misunderstanding the sentence structure here, I believe the word
> "a" is missing before "parallel query plan" in the following sentence from
> section 15.2:
>
> > Even when parallel query plan is generated for a particular query, there
> are several circumstances under which it will be impossible to execute that
> plan in parallel at execution time.
>
> This should say:
>
> > Even when a parallel query plan is generated for a particular query, there
> are several circumstances under which it will be impossible to execute that
> plan in parallel at execution time.

+1

Here is a patch for that; it may be the smallest patch I've ever
written for PostgreSQL.

Yours,
Laurenz Albe

Attachment

Re: Incorrect grammar in 15.2

From
Alvaro Herrera
Date:
On 2024-Jul-24, Laurenz Albe wrote:

> Here is a patch for that; it may be the smallest patch I've ever
> written for PostgreSQL.

Thanks, applied.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Investigación es lo que hago cuando no sé lo que estoy haciendo"
(Wernher von Braun)