Thread: Fix an incorrect statement for failover option in alter_subscription.sgml

Hi,

The documentation incorrectly stated that users cannot alter subscription's
failover option when two-phase commit is enabled.

When writing this doc, I only wanted to mention we cannot execute ALTER SUB SET
(failover) in a transaction block, but I missed the following statement for
two-phase commit which causes the incorrect understanding. Here is a small
patch to fix it.

Best Regards,
Hou Zhijie

On Friday, July 19, 2024 1:13 PM Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com> wrote:
>
> Hi,
>
> The documentation incorrectly stated that users cannot alter subscription's
> failover option when two-phase commit is enabled.
>
> When writing this doc, I only wanted to mention we cannot execute ALTER SUB
> SET
> (failover) in a transaction block, but I missed the following statement for
> two-phase commit which causes the incorrect understanding. Here is a small
> patch to fix it.

CC Amit who originally committed the doc change.

Best Regards,
Hou zj

On Fri, Jul 19, 2024 at 10:43 AM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
>
> Hi,
>
> The documentation incorrectly stated that users cannot alter subscription's
> failover option when two-phase commit is enabled.
>
> When writing this doc, I only wanted to mention we cannot execute ALTER SUB SET
> (failover) in a transaction block, but I missed the following statement for
> two-phase commit which causes the incorrect understanding. Here is a small
> patch to fix it.

The patch looks good to me except there is repetition of commands in
both the lines now. But I could not think of  a better way. So I think
it is okay to have this way.

thanks
Shveta

On Mon, Jul 22, 2024 at 10:45 AM shveta malik <shveta.malik@gmail.com> wrote:
>
> On Fri, Jul 19, 2024 at 10:43 AM Zhijie Hou (Fujitsu)
> <houzj.fnst@fujitsu.com> wrote:
> >
> > Hi,
> >
> > The documentation incorrectly stated that users cannot alter subscription's
> > failover option when two-phase commit is enabled.
> >
> > When writing this doc, I only wanted to mention we cannot execute ALTER SUB SET
> > (failover) in a transaction block, but I missed the following statement for
> > two-phase commit which causes the incorrect understanding. Here is a small
> > patch to fix it.
>
> The patch looks good to me except there is repetition of commands in
> both the lines now. But I could not think of  a better way. So I think
> it is okay to have this way.
>

Thanks for the review. I also couldn't think of a better way to
document this information. The patch as proposed looks good to me.

--
With Regards,
Amit Kapila.