Postgres Pro
Downloads
Home   >   mailing lists

Thread: Remove redundant HandleWalWriterInterrupts()

Remove redundant HandleWalWriterInterrupts()

From
Fujii Masao
Date:
Hi,

Because of commit 1bdd54e662, the code of HandleWalWriterInterrupts()
became the same as HandleMainLoopInterrupts(). So I'd like to propose to
remove HandleWalWriterInterrupts() and make walwriter use
HandleMainLoopInterrupts() instead for improved code simplicity. Thought?

Patch attached.

Regards,

-- 
Fujii Masao
Attachment

Re: Remove redundant HandleWalWriterInterrupts()

From
Bharath Rupireddy
Date:
On Wed, Jan 24, 2024 at 5:50 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> Hi,
>
> Because of commit 1bdd54e662, the code of HandleWalWriterInterrupts()
> became the same as HandleMainLoopInterrupts(). So I'd like to propose to
> remove HandleWalWriterInterrupts() and make walwriter use
> HandleMainLoopInterrupts() instead for improved code simplicity. Thought?
>
> Patch attached.

Nice catch. Indeed they both are the same after commit 1bdd54e662. The
patch LGTM.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Re: Remove redundant HandleWalWriterInterrupts()

From
Nathan Bossart
Date:
On Wed, Jan 24, 2024 at 07:30:17PM +0530, Bharath Rupireddy wrote:
> On Wed, Jan 24, 2024 at 5:50 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>> Because of commit 1bdd54e662, the code of HandleWalWriterInterrupts()
>> became the same as HandleMainLoopInterrupts(). So I'd like to propose to
>> remove HandleWalWriterInterrupts() and make walwriter use
>> HandleMainLoopInterrupts() instead for improved code simplicity. Thought?
>>
>> Patch attached.
> 
> Nice catch. Indeed they both are the same after commit 1bdd54e662. The
> patch LGTM.

LGTM, too.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Re: Remove redundant HandleWalWriterInterrupts()

From
Fujii Masao
Date:
On Thu, Jan 25, 2024 at 4:40 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Wed, Jan 24, 2024 at 07:30:17PM +0530, Bharath Rupireddy wrote:
> > On Wed, Jan 24, 2024 at 5:50 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> >> Because of commit 1bdd54e662, the code of HandleWalWriterInterrupts()
> >> became the same as HandleMainLoopInterrupts(). So I'd like to propose to
> >> remove HandleWalWriterInterrupts() and make walwriter use
> >> HandleMainLoopInterrupts() instead for improved code simplicity. Thought?
> >>
> >> Patch attached.
> >
> > Nice catch. Indeed they both are the same after commit 1bdd54e662. The
> > patch LGTM.
>
> LGTM, too.

Thank you both for reviewing! I've pushed the patch.

Regards,

--
Fujii Masao