Re: Remove redundant HandleWalWriterInterrupts() - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Remove redundant HandleWalWriterInterrupts()
Date
Msg-id CAHGQGwEt-gqiYbF2cf=JZrxcYjmgCfy4NN4ixyKWu674ghAkzw@mail.gmail.com
Whole thread Raw
In response to Re: Remove redundant HandleWalWriterInterrupts()  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
On Thu, Jan 25, 2024 at 4:40 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Wed, Jan 24, 2024 at 07:30:17PM +0530, Bharath Rupireddy wrote:
> > On Wed, Jan 24, 2024 at 5:50 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> >> Because of commit 1bdd54e662, the code of HandleWalWriterInterrupts()
> >> became the same as HandleMainLoopInterrupts(). So I'd like to propose to
> >> remove HandleWalWriterInterrupts() and make walwriter use
> >> HandleMainLoopInterrupts() instead for improved code simplicity. Thought?
> >>
> >> Patch attached.
> >
> > Nice catch. Indeed they both are the same after commit 1bdd54e662. The
> > patch LGTM.
>
> LGTM, too.

Thank you both for reviewing! I've pushed the patch.

Regards,

--
Fujii Masao



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Guiding principle for dropping LLVM versions?
Next
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Synchronizing slots from primary to standby