Thread: Remove references to pre-11 versions

Remove references to pre-11 versions

From
Thom Brown
Date:
Hi,

I've attached a patch that removes some now redundant messaging about
unsupported versions.

Regards

Thom

Attachment

Re: Remove references to pre-11 versions

From
Tom Lane
Date:
Thom Brown <thom@linux.com> writes:
> I've attached a patch that removes some now redundant messaging about
> unsupported versions.

If we want to make that a policy, I think a lot more could be done
--- I remember noticing a documentation comment about some 8.x
version just recently.

However, "out of support" is a lot different from "nobody has any
code written for that version anymore".  So I'd be inclined to keep
the first hunk in your patch, the one explaining the regexp_matches-
in-a-subselect trick.  People will be trying to puzzle out why
somebody did it like that for years to come.

I agree with simplifying the other two spots.

            regards, tom lane



Re: Remove references to pre-11 versions

From
Thom Brown
Date:
On Wed, 19 Apr 2023 at 14:58, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Thom Brown <thom@linux.com> writes:
> > I've attached a patch that removes some now redundant messaging about
> > unsupported versions.
>
> If we want to make that a policy, I think a lot more could be done
> --- I remember noticing a documentation comment about some 8.x
> version just recently.
>
> However, "out of support" is a lot different from "nobody has any
> code written for that version anymore".  So I'd be inclined to keep
> the first hunk in your patch, the one explaining the regexp_matches-
> in-a-subselect trick.  People will be trying to puzzle out why
> somebody did it like that for years to come.
>
> I agree with simplifying the other two spots.

Fair enough.  I've updated the patch.  However, feel free to ignore if
this marks the thin edge of the wedge.

Thom

Attachment

Re: Remove references to pre-11 versions

From
Peter Eisentraut
Date:
On 19.04.23 14:37, Thom Brown wrote:
> I've attached a patch that removes some now redundant messaging about
> unsupported versions.

The text in pg_basebackup.sgml describes behavior that still exists in 
pg_basebackup.  As long as that behavior exists, we should document it 
accurately.