Thread: pg_basebackup: Correct type of WalSegSz

pg_basebackup: Correct type of WalSegSz

From
Peter Eisentraut
Date:
The pg_basebackup code has WalSegSz as uint32, whereas the rest of the 
code has it as int.  This seems confusing, and using the extra range 
wouldn't actually work.  This was in the original commit (fc49e24fa6), 
but I suppose it was an oversight.
Attachment

Re: pg_basebackup: Correct type of WalSegSz

From
Daniel Gustafsson
Date:
> On 30 Mar 2023, at 08:24, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
>
> The pg_basebackup code has WalSegSz as uint32, whereas the rest of the code has it as int.  This seems confusing, and
usingthe extra range wouldn't actually work.  This was in the original commit (fc49e24fa6), but I suppose it was an
oversight.

LGTM, it indeed seems to be an accidental oversight.

--
Daniel Gustafsson