Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_basebackup: Correct type of WalSegSz - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: pg_basebackup: Correct type of WalSegSz
Date
Msg-id 033DFBE7-694D-4C35-8146-8FBB64F0673F@yesql.se
Whole thread Raw
In response to pg_basebackup: Correct type of WalSegSz  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
Tree view 
> On 30 Mar 2023, at 08:24, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
>
> The pg_basebackup code has WalSegSz as uint32, whereas the rest of the code has it as int.  This seems confusing, and
usingthe extra range wouldn't actually work.  This was in the original commit (fc49e24fa6), but I suppose it was an
oversight.

LGTM, it indeed seems to be an accidental oversight.

--
Daniel Gustafsson

pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: Experiments with Postgres and SSL
Next
From: Daniel Gustafsson
Date:
Subject: Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert