Thread: shoud be get_extension_schema visible?

shoud be get_extension_schema visible?

From
Pavel Stehule
Date:
Hi

more times I needed to get the extension's assigned namespace. There is already a cooked function get_extension_schema, but it is static. 

I need to find a function with a known name, but possibly an unknown schema from a known extension.

Regards

Pavel


Re: shoud be get_extension_schema visible?

From
Pavel Stehule
Date:
Hi


pá 17. 2. 2023 v 6:45 odesílatel Pavel Stehule <pavel.stehule@gmail.com> napsal:
Hi

more times I needed to get the extension's assigned namespace. There is already a cooked function get_extension_schema, but it is static. 

I need to find a function with a known name, but possibly an unknown schema from a known extension.

Here is an patch

Regards

Pavel
 

Regards

Pavel


Attachment

Re: shoud be get_extension_schema visible?

From
Julien Rouhaud
Date:
Hi,

On Sun, Feb 19, 2023 at 06:40:39AM +0100, Pavel Stehule wrote:
>
> pá 17. 2. 2023 v 6:45 odesílatel Pavel Stehule <pavel.stehule@gmail.com>
> napsal:
>
> > more times I needed to get the extension's assigned namespace. There is
> > already a cooked function get_extension_schema, but it is static.
> >
> > I need to find a function with a known name, but possibly an unknown
> > schema from a known extension.
> >
>
> Here is an patch

The patch is trivial so I don't have much to say about it, and it also seems
quite reasonable generally.

Note for other reviewers / committers: this is a something actually already
wanted for 3rd party code.  As an example, here's Pavel's code in plpgsql_check
extension that internally has to duplicate this function (and deal with
compatibility):
https://github.com/okbob/plpgsql_check/blob/master/src/catalog.c#L205

I'm marking this entry as Ready For Committer.



Re: shoud be get_extension_schema visible?

From
Pavel Stehule
Date:


po 6. 3. 2023 v 8:33 odesílatel Julien Rouhaud <rjuju123@gmail.com> napsal:
Hi,

On Sun, Feb 19, 2023 at 06:40:39AM +0100, Pavel Stehule wrote:
>
> pá 17. 2. 2023 v 6:45 odesílatel Pavel Stehule <pavel.stehule@gmail.com>
> napsal:
>
> > more times I needed to get the extension's assigned namespace. There is
> > already a cooked function get_extension_schema, but it is static.
> >
> > I need to find a function with a known name, but possibly an unknown
> > schema from a known extension.
> >
>
> Here is an patch

The patch is trivial so I don't have much to say about it, and it also seems
quite reasonable generally.

Note for other reviewers / committers: this is a something actually already
wanted for 3rd party code.  As an example, here's Pavel's code in plpgsql_check
extension that internally has to duplicate this function (and deal with
compatibility):
https://github.com/okbob/plpgsql_check/blob/master/src/catalog.c#L205

I'm marking this entry as Ready For Committer.

Thank you very much

Pavel

Re: shoud be get_extension_schema visible?

From
Michael Paquier
Date:
On Mon, Mar 06, 2023 at 08:34:49AM +0100, Pavel Stehule wrote:
>> Note for other reviewers / committers: this is a something actually already
>> wanted for 3rd party code.  As an example, here's Pavel's code in
>> plpgsql_check
>> extension that internally has to duplicate this function (and deal with
>> compatibility):
>> https://github.com/okbob/plpgsql_check/blob/master/src/catalog.c#L205

I can see why you'd want that, so OK from here to provide this routine
for external consumption.  Let's first wait a bit and see if others
have any kind of objections or comments.
--
Michael

Attachment

Re: shoud be get_extension_schema visible?

From
Michael Paquier
Date:
On Mon, Mar 06, 2023 at 04:44:59PM +0900, Michael Paquier wrote:
> I can see why you'd want that, so OK from here to provide this routine
> for external consumption.  Let's first wait a bit and see if others
> have any kind of objections or comments.

Done this one as of e20b1ea.
--
Michael

Attachment

Re: shoud be get_extension_schema visible?

From
Pavel Stehule
Date:


st 8. 3. 2023 v 2:04 odesílatel Michael Paquier <michael@paquier.xyz> napsal:
On Mon, Mar 06, 2023 at 04:44:59PM +0900, Michael Paquier wrote:
> I can see why you'd want that, so OK from here to provide this routine
> for external consumption.  Let's first wait a bit and see if others
> have any kind of objections or comments.

Done this one as of e20b1ea.

Thank you very much

Pavel
 
--
Michael