Postgres Pro
Downloads
Home   >   mailing lists

Thread: Fix comments atop pg_get_replication_slots

Fix comments atop pg_get_replication_slots

From
sirisha chamarthi
Date:
Hi Hackers,

The comments atop seem to indicate that it is only showing active replication slots. The comment is ambiguous as it also shows all the slots including lost and inactive slots. Attached a small patch to fix it.

Thanks,
Sirisha
Attachment

Re: Fix comments atop pg_get_replication_slots

From
Amit Kapila
Date:
On Mon, Nov 21, 2022 at 12:45 PM sirisha chamarthi
<sirichamarthi22@gmail.com> wrote:
>
> Hi Hackers,
>
> The comments atop seem to indicate that it is only showing active replication slots. The comment is ambiguous as it
alsoshows all the slots including lost and inactive slots. Attached a small patch to fix it.
 
>

I agree that it is a bit confusing. How about "SQL SRF showing all
replication slots that currently exist on the database cluster"?

-- 
With Regards,
Amit Kapila.

Re: Fix comments atop pg_get_replication_slots

From
sirisha chamarthi
Date:
Amit, thanks for looking into this!

On Sun, Nov 20, 2022 at 11:38 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Mon, Nov 21, 2022 at 12:45 PM sirisha chamarthi
<sirichamarthi22@gmail.com> wrote:
>
> Hi Hackers,
>
> The comments atop seem to indicate that it is only showing active replication slots. The comment is ambiguous as it also shows all the slots including lost and inactive slots. Attached a small patch to fix it.
>

I agree that it is a bit confusing. How about "SQL SRF showing all
replication slots that currently exist on the database cluster"?

Looks good to me. Attached a patch for the same.
 

--
With Regards,
Amit Kapila.
Attachment

Re: Fix comments atop pg_get_replication_slots

From
Amit Kapila
Date:
On Mon, Nov 21, 2022 at 1:22 PM sirisha chamarthi
<sirichamarthi22@gmail.com> wrote:
>
> Looks good to me. Attached a patch for the same.
>

Pushed.

-- 
With Regards,
Amit Kapila.