Thread: Fix comments atop ReorderBufferAddInvalidations
The comments atop seem to indicate that we always accumulate invalidation messages in top-level transactions which is neither required nor match with the code. This is introduced in the commit c55040ccd0 and I have observed it while working on a fix for commit 16b1fe0037. -- With Regards, Amit Kapila.
Attachment
Hi On Thu, Nov 3, 2022 at 7:53 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > The comments atop seem to indicate that we always accumulate > invalidation messages in top-level transactions which is neither > required nor match with the code. This is introduced in the commit > c55040ccd0 and I have observed it while working on a fix for commit > 16b1fe0037. Thank you for the patch. It looks good to me. I think we can backpatch it to avoid confusion in future. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
On Fri, Nov 4, 2022 at 11:14 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > On Thu, Nov 3, 2022 at 7:53 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > The comments atop seem to indicate that we always accumulate > > invalidation messages in top-level transactions which is neither > > required nor match with the code. This is introduced in the commit > > c55040ccd0 and I have observed it while working on a fix for commit > > 16b1fe0037. > > Thank you for the patch. It looks good to me. > > I think we can backpatch it to avoid confusion in future. > Pushed. -- With Regards, Amit Kapila.