Re: Fix comments atop ReorderBufferAddInvalidations - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Fix comments atop ReorderBufferAddInvalidations
Date
Msg-id CAD21AoDvQqKDbZ6BZuFqx4n3OuSVEEL_ZdKLEHdND9SW32qygQ@mail.gmail.com
Whole thread Raw
In response to Fix comments atop ReorderBufferAddInvalidations  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Fix comments atop ReorderBufferAddInvalidations
List pgsql-hackers
Hi

On Thu, Nov 3, 2022 at 7:53 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> The comments atop seem to indicate that we always accumulate
> invalidation messages in top-level transactions which is neither
> required nor match with the code. This is introduced in the commit
> c55040ccd0 and I have observed it while working on a fix for commit
> 16b1fe0037.

Thank you for the patch. It looks good to me.

I think we can backpatch it to avoid confusion in future.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Ian Lawrence Barwick
Date:
Subject: Re: Commit fest 2022-11
Next
From: Pavel Stehule
Date:
Subject: Re: PL/pgSQL cursors should get generated portal names by default