Thread: Add a missing comment for PGPROC.pgprocno

Hi hackers,

I tried to understand some implementation details of ProcArray and
discovered that this is a bit challenging to do due to a missing
comment for PGPROC.pgprocno. E.g. it's hard to understand why
ProcArrayAdd() preserves procArray->pgprocnos[] sorted by (PGPROC *)
if actually the sorting is done by pgprocno. Took me some time to
figure this out.

Here is the patch that fixes this. Hopefully this will save some time
for the newcomers.

-- 
Best regards,
Aleksander Alekseev

On Thu, Sep  8, 2022 at 08:16:07PM +0300, Aleksander Alekseev wrote:
> Hi hackers,
> 
> I tried to understand some implementation details of ProcArray and
> discovered that this is a bit challenging to do due to a missing
> comment for PGPROC.pgprocno. E.g. it's hard to understand why
> ProcArrayAdd() preserves procArray->pgprocnos[] sorted by (PGPROC *)
> if actually the sorting is done by pgprocno. Took me some time to
> figure this out.
> 
> Here is the patch that fixes this. Hopefully this will save some time
> for the newcomers.

Thanks, patch applied to master.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Indecision is a decision.  Inaction is an action.  Mark Batterson