Postgres Pro
Downloads
Home   >   mailing lists

Re: Add a missing comment for PGPROC.pgprocno - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Add a missing comment for PGPROC.pgprocno
Date
Msg-id Y0WjDwIOG69XBlqJ@momjian.us
Whole thread Raw
In response to Add a missing comment for PGPROC.pgprocno  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
Tree view 
On Thu, Sep  8, 2022 at 08:16:07PM +0300, Aleksander Alekseev wrote:
> Hi hackers,
> 
> I tried to understand some implementation details of ProcArray and
> discovered that this is a bit challenging to do due to a missing
> comment for PGPROC.pgprocno. E.g. it's hard to understand why
> ProcArrayAdd() preserves procArray->pgprocnos[] sorted by (PGPROC *)
> if actually the sorting is done by pgprocno. Took me some time to
> figure this out.
> 
> Here is the patch that fixes this. Hopefully this will save some time
> for the newcomers.

Thanks, patch applied to master.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Indecision is a decision.  Inaction is an action.  Mark Batterson

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Clarifying docs on nuance of select and update policies
Next
From: Zhihong Yu
Date:
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands