Thread: BUG #17333: pgdg postgresql-common pg_upgradecluster duplicate data_directory in configuration file

The following bug has been logged on the website:

Bug reference:      17333
Logged by:          Eric Meygret
Email address:      eric.meygret@free.fr
PostgreSQL version: 14.1
Operating system:   Ubuntu 20.04
Description:

Hello,
first I want to say that this bug could delete all data, and second sorry
for my bad English.

I tried to upgrade a database from 9.6 to 14(but I think it is the same for
any migrations). 
in /etc/postgresql/9.6/main/postgresql.conf I have to times data_directory
first default value:
data_directory = '/var/lib/postgresql/9.6/main' 
and at the end of file
data_directory = '/postgresql/9.6/main/' 

postgresql ignore first value.

when I launch upgrade with 
pg_upgradecluster -v 14 --method=link --link 9.6 main /postgresql/14/main/

upgrade copy /etc/postgresql/9.6/main/postgresql.conf  to
/etc/postgresql/14/main/postgresql.conf 
and replace first occurrence  so I have :
data_directory = '/postgresql/14/main/' 
and at then end of the configuration file : 
data_directory = '/postgresql/9.6/main/' 

the upgrade failed and start a pg_dropcluster 14 main and this one use the
last occurrence so delete /postgresql/9.6/main/

and now all data are lost. (thanks to backup before upgrade :) ) 

hope that my explanation is correct and understandable.

The following bug has been logged on the website:

Bug reference:      17333
Logged by:          Eric Meygret
Email address:      eric.meygret@free.fr
PostgreSQL version: 14.1
Operating system:   Ubuntu 20.04
Description:       

postgresql ignore first value.

when I launch upgrade with
pg_upgradecluster -v 14 --method=link --link 9.6 main /postgresql/14/main/

upgrade copy /etc/postgresql/9.6/main/postgresql.conf  to
/etc/postgresql/14/main/postgresql.conf
and replace first occurrence  so I have :
data_directory = '/postgresql/14/main/' 

and now all data are lost. (thanks to backup before upgrade :) ) 

hope that my explanation is correct and understandable.

>> That script isn’t part of the core project so this list may not be the best place to report complaints.
sorry I was thinking that you mange also pgdg repository, where I can report that, I am afraid that to have same answer
bythe Debian team?  

>> Doing testing on in a test environment first is another useful exercise.
That was on a test environnement :)

>> If you are going to go do customizations the fact that the scripts that are built without those customizations in
mindfail to work properly isn’t a bug. I’d suggest you simply use the pg_upgrade tool directly if you don’t like (or
adhereto) the assumptions built into the distro-specific scripts.  
I like this tools, but I don't think that it is a choice to not follow "your" assumptions(I mean ignore first value),
especiallyif it could lead to the deletion of data, but maybe I wrong.  

thanks for your answer.
Eric