Thread: pgsql: Fix inappropriate uses of PG_GETARG_UINT32()
Fix inappropriate uses of PG_GETARG_UINT32() The chr() function used PG_GETARG_UINT32() even though the argument is declared as (signed) integer. As a result, you can pass negative arguments to this function and it internally interprets them as positive. Ultimately ends up being harmless, but it seems wrong, so fix this and rearrange the internal error checking a bit to accommodate this. Another case was in the documentation, where example code used PG_GETARG_UINT32() with an argument declared as signed integer. Reviewed-by: Nathan Bossart <bossartn@amazon.com> Discussion: https://www.postgresql.org/message-id/flat/7e43869b-d412-8f81-30a3-809783edc9a3%40enterprisedb.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e9e63b7022ddd0aaaae7cd439daa234cf9e6a21c Modified Files -------------- doc/src/sgml/xfunc.sgml | 2 +- src/backend/utils/adt/oracle_compat.c | 33 ++++++++++++++++++++------------- 2 files changed, 21 insertions(+), 14 deletions(-)